Code Review Checklist
Comprehensive code review checklist for developers. Quality, security, performance, testing. Ensure high-quality code before merge.
Code Quality
Follows coding standards and style guide
Meaningful variable and function names
No unnecessary complexity
No duplicate code (DRY principle)
Functions are small and focused
No magic numbers or hardcoded values
Proper use of constants and enums
Error Handling
All exceptions handled properly
Error messages are clear and helpful
Edge cases covered
Null/undefined checks where needed
Graceful degradation implemented
Logging appropriate for debugging
Security
No SQL injection vulnerabilities
No XSS vulnerabilities
Input validation and sanitization
Authentication checks present
Authorization/permission checks
Sensitive data encrypted
No hardcoded secrets/credentials
HTTPS enforced for sensitive data
Performance
No unnecessary loops or iterations
Database queries optimized
Memory leaks avoided
Caching implemented where beneficial
Large operations paginated/streamed
Lazy loading considered
Testing
Unit tests cover new functionality
Edge cases tested
Integration tests where needed
Tests are maintainable
Mock data appropriate
Test coverage acceptable
Documentation
Code is self-documenting
Complex logic has comments
Public APIs documented
README updated if needed
Change log updated
Migration guide if breaking change
Architecture
Follows project architecture patterns
Dependencies appropriate and minimal
No circular dependencies
Separation of concerns maintained
Interfaces used appropriately
Module boundaries respected
Review Process Tips
Review in small chunks (400 lines max). Focus on logic, not style (use linter). Ask questions, don't demand. Explain why changes matter. Be respectful and constructive. Approve when ready. Use PR templates. Automate with CI checks. Balance thoroughness and speed.
Common Review Issues
Unclear variable names
Missing error handling
Hardcoded values
Missing tests
Security vulnerabilities
Performance issues
Over-engineering
Breaking changes
Feedback Phrases
Good: "Consider using..." "What if..." "Could you explain..." Bad: "This is wrong" "Change this" "I don't like this". Frame as suggestions, ask for clarification, explain reasoning. Positive: "Good catch" "Nice implementation" "LGTM". Constructive feedback improves team.